fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] fynmanoj commented on a change in pull request #1346: FINERACT-1151-fix
Date Thu, 24 Sep 2020 04:57:04 GMT

fynmanoj commented on a change in pull request #1346:
URL: https://github.com/apache/fineract/pull/1346#discussion_r494038663



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
     public boolean isEMIFixedSpecificToInstallment() {
         return isEMIFixedSpecificToInstallment;
     }
+
+    @Override
+    public BigDecimal rescheduleInterestPortion() {
+        return null;

Review comment:
       There is one of the two implimentations of the interface "LoanScheduleModelPeriod"
(Disbursement period and Repayment Period).  These methods are not significant for Disbursement
Period and needed only in Repayment Period, hence they are marked dummy.

##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
     public boolean isEMIFixedSpecificToInstallment() {
         return isEMIFixedSpecificToInstallment;
     }
+
+    @Override
+    public BigDecimal rescheduleInterestPortion() {
+        return null;
+    }
+
+    @Override
+    public void setRescheduleInterestPortion(BigDecimal rescheduleInterestPortion) {
+        return;

Review comment:
       There is one of the two implimentations of the interface "LoanScheduleModelPeriod"
(Disbursement period and Repayment Period).  These methods are not significant for Disbursement
Period and needed only in Repayment Period, hence they are marked dummy.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message