fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] percyashu commented on a change in pull request #1184: FINERACT-1089 removing the rs.previous()
Date Wed, 23 Sep 2020 04:54:26 GMT

percyashu commented on a change in pull request #1184:
URL: https://github.com/apache/fineract/pull/1184#discussion_r493177869



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountInterestRateChartReadPlatformServiceImpl.java
##########
@@ -305,12 +305,8 @@ public DepositAccountInterestRateChartSlabData extractData(ResultSet
rs) throws
                     if (incentiveData != null) {
                         chartSlabData.addIncentives(incentiveData);
                     }
-                } else {
-                    rs.previous();

Review comment:
       @vorburger Yeah I will make time, just the issues of setting up a test case to ensure
the output stays unchanged and if you can confirm the functional knowledge of the data model.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message