fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] SubhamPramanik commented on a change in pull request #1330: Interop KYC and Interop Loan Disbursement
Date Wed, 23 Sep 2020 04:39:56 GMT

SubhamPramanik commented on a change in pull request #1330:
URL: https://github.com/apache/fineract/pull/1330#discussion_r493073446



##########
File path: fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
##########
@@ -437,6 +550,19 @@ private SavingsAccount validateAndGetSavingAccount(@NotNull InteropRequestData
r
         return savingsAccount;
     }
 
+    // private Loan validateAndGetLoan(@NotNull InteropRequestData request) {

Review comment:
       Removed

##########
File path: fineract-provider/src/main/java/org/apache/fineract/interoperation/api/InteropApiResource.java
##########
@@ -373,4 +374,29 @@ public String performTransfer(@QueryParam("action") @Parameter(description
= "ac
 
         return jsonSerializer.serialize(settings, result);
     }
+
+    @GET
+    @Consumes({ MediaType.APPLICATION_JSON })
+    @Produces({ MediaType.APPLICATION_JSON })
+    @Path("accounts/{accountId}/kyc")
+    @Operation(summary = "Query KYC by Account Id", description = "")
+    @ApiResponses({
+            @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema
= @Schema(implementation = InteropKycResponseData.class))) })
+    public String getClientKyc(@PathParam("accountId") @Parameter(description = "accountId")
String accountId, @Context UriInfo uriInfo) {
+        InteropKycResponseData result = interopService.getKyc(accountId);
+        ApiRequestJsonSerializationSettings settings = this.apiRequestParameterHelper.process(uriInfo.getQueryParameters());

Review comment:
       Not sure how to do it. Can you point to a refernce implementation? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message