fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on pull request #1330: Interop KYC and Interop Loan Disbursement
Date Tue, 22 Sep 2020 19:36:00 GMT

thesmallstar commented on pull request #1330:
URL: https://github.com/apache/fineract/pull/1330#issuecomment-696935962


   @SubhamPramanik  thank you for the PR, I see a checkstyle error in your code, that means
address_line_1 that you made does not match the required regex it should.
   
   I also see a AvoidHidingCauseException, that happens when you catch a exception and throw
another exception essentially hiding what actually caused the exception! 
   
   Will you fix this?
   
   cc @vorburger The checkstyles are helping!!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message