fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)
Date Mon, 21 Sep 2020 07:44:54 GMT

thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491846195



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/GlobalConfigurationHelper.java
##########
@@ -41,18 +41,17 @@ public GlobalConfigurationHelper(final RequestSpecification requestSpec,
final R
 
     public static ArrayList<HashMap> getAllGlobalConfigurations(final RequestSpecification
requestSpec,
             final ResponseSpecification responseSpec) {
-        final String GET_ALL_GLOBAL_CONFIG_URL = "/fineract-provider/api/v1/configurations?"
+ Utils.TENANT_IDENTIFIER;
+        final String getAllGlobalConfigURL = "/fineract-provider/api/v1/configurations?"
+ Utils.TENANT_IDENTIFIER;
         LOG.info("------------------------ RETRIEVING ALL GLOBAL CONFIGURATIONS -------------------------");
-        final HashMap<String, ArrayList<HashMap>> response = Utils.performServerGet(requestSpec,
responseSpec, GET_ALL_GLOBAL_CONFIG_URL,
-                "");
+        final HashMap<String, ArrayList<HashMap>> response = Utils.performServerGet(requestSpec,
responseSpec, getAllGlobalConfigURL, "");
         return response.get("globalConfiguration");
     }
 
     public static HashMap getGlobalConfigurationById(final RequestSpecification requestSpec,
final ResponseSpecification responseSpec,
             final String configId) {
-        final String GET_GLOBAL_CONFIG_BY_ID_URL = "/fineract-provider/api/v1/configurations/"
+ configId + "?" + Utils.TENANT_IDENTIFIER;
+        final String getGlobalConfigByIDurl = "/fineract-provider/api/v1/configurations/"
+ configId + "?" + Utils.TENANT_IDENTIFIER;
         LOG.info("------------------------ RETRIEVING GLOBAL CONFIGURATION BY ID -------------------------");

Review comment:
       updated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message