fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)
Date Mon, 21 Sep 2020 07:41:56 GMT

thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491844647



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/StandingInstructionsHelper.java
##########
@@ -108,20 +108,20 @@ public Integer createStandingInstruction(final String clientId, final
String fro
     public HashMap getStandingInstructionById(final String standingInstructionId) {
 
         LOG.info("----------------------------- RETRIEVING STANDING INSTRUCTION BY ID---------------------------");
-        final String GET_STANDING_INSTRUCTION_BY_ID_URL = STANDING_INSTRUCTIONS_URL + "/"
+ standingInstructionId + "?"
+        final String getStandingInstructionsByIDurl = STANDING_INSTRUCTIONS_URL + "/" + standingInstructionId
+ "?"
                 + Utils.TENANT_IDENTIFIER;

Review comment:
       updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message