From commits-return-11875-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Thu Aug 27 08:00:08 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 3D66F18063B for ; Thu, 27 Aug 2020 10:00:08 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 5A455123DD5 for ; Thu, 27 Aug 2020 08:00:07 +0000 (UTC) Received: (qmail 84195 invoked by uid 500); 27 Aug 2020 08:00:07 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 84185 invoked by uid 99); 27 Aug 2020 08:00:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Aug 2020 08:00:07 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_ptuomola_commented_on_a_change_in_pull?= =?utf-8?q?_request_=231292=3A_FINERACT-1129=3A_Gradle_task_to_create_releas?= =?utf-8?q?e_package?= Message-ID: <159851520691.32230.11710599208795191239.asfpy@gitbox.apache.org> Date: Thu, 27 Aug 2020 08:00:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: ptuomola commented on a change in pull request #1292: URL: https://github.com/apache/fineract/pull/1292#discussion_r478230261 ########## File path: README.md ########## @@ -353,6 +353,41 @@ Releasing [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents the process how we make the source code that is available here in this Git repository into a binary release ZIP available on http://fineract.apache.org. +Before you use Gradle to create a release you need to make sure that your GPG is properly setup and that you have set the following properties in your ~/gradle/gradle.properties: +``` +signing.gnupg.keyName=7890ABCD +signing.gnupg.passphrase=secret +``` + +IMPORTANT: Do not set your GPG secrets in one of the project gradle.properties and double check that you are not accidentally committing them to Git. + +NOTE: Let's assume your GPG key ID would be "ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890ABCD" then you have to use the last 8 characters (i. e. "7890ABCD") for the signing plugin property "signing.gnupg.keyName". + +Execute the following task to create a distribution with an ASCII armored signature (.asc) and a SHA512 checksum file (.sha512): +``` +./gradlew -Pfineract.release clean build +``` Review comment: OK - if it's been decided, then that's fine. Personally I would have preferred that all different activities are triggered as tasks: it's a bit confusing now that all other activities are triggered as tasks and only these with a profile. Also as far as I know, you can only have one profile active - correct? So if in the future we want to have different types of builds activated as profiles, you can't create distributions of them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org