From commits-return-11650-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Thu Aug 20 04:26:39 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 070F418062C for ; Thu, 20 Aug 2020 06:26:39 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 1FE8A12592A for ; Thu, 20 Aug 2020 04:26:38 +0000 (UTC) Received: (qmail 22812 invoked by uid 500); 20 Aug 2020 04:26:37 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 22802 invoked by uid 99); 20 Aug 2020 04:26:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2020 04:26:37 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_ptuomola_commented_on_pull_request_=23?= =?utf-8?q?1242=3A_FINERACT-821_Added_and_Enforced_MemberName_Checkstyle=282?= =?utf-8?q?=29?= Message-ID: <159789759719.32230.16469112428693741943.asfpy@gitbox.apache.org> Date: Thu, 20 Aug 2020 04:26:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: ptuomola commented on pull request #1242: URL: https://github.com/apache/fineract/pull/1242#issuecomment-677025303 @thesmallstar Thanks for your reply! I think it's all just a matter of preference and what you're used to seeing :-) But I think consistency is more important than trying to adhere to anyone's specific preferences. So to make things consistent re member naming, let's merge your change as proposed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org