fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] Grandolf49 opened a new pull request #1270: FINERACT-1105 Swagger now generates a valid spec file
Date Sun, 23 Aug 2020 11:26:55 GMT

Grandolf49 opened a new pull request #1270:
URL: https://github.com/apache/fineract/pull/1270


   ## Description
   FINERACT-1105
   
   It is essential that Swagger Gradle Plugin generates a valid spec file so that Swagger
Codegen is able to generate a valid client library. Earlier, swagger was generating an invalid
spec file due to some missing elements in the source code. This PR fixes the issue. Some APIs
were missing Path Parameter. So I have added it in the appropriate methods. Still exploring
if this can be avoided.
   
   This is an example of a valid spec file generated by swagger: [fineract-valid-spec.yaml](https://gist.github.com/Grandolf49/5f97ac65f689a73eaa4b386b1d01b51f)

   Test it using https://validator.swagger.io/
   
   This is the earlier spec file: [fineract.yaml](https://gist.github.com/Grandolf49/7101c0dd473b76f18ae3e801b1be4bb4)
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/.
Ex: FINERACT-646 Pockets API.
   
   - [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
have been followed.
   
   - [x] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm
has been updated with details of any API changes.
   
   - [x] Integration tests have been created/updated for verifying the changes made.
   
   - [x] All Integrations tests are passing with the new commits.
   
   - [x] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message