fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package
Date Thu, 27 Aug 2020 08:38:50 GMT

vidakovic commented on a change in pull request #1292:
URL: https://github.com/apache/fineract/pull/1292#discussion_r478252724



##########
File path: README.md
##########
@@ -353,6 +353,41 @@ Releasing
 
 [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents the
process how we make the source code that is available here in this Git repository into a binary
release ZIP available on http://fineract.apache.org.
 
+Before you use Gradle to create a release you need to make sure that your GPG is properly
setup and that you have set the following properties in your ~/gradle/gradle.properties:
+```
+signing.gnupg.keyName=7890ABCD
+signing.gnupg.passphrase=secret
+```
+
+IMPORTANT: Do not set your GPG secrets in one of the project gradle.properties and double
check that you are not accidentally committing them to Git.
+
+NOTE: Let's assume your GPG key ID would be "ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890ABCD" then
you have to use the last 8 characters (i. e. "7890ABCD") for the signing plugin property "signing.gnupg.keyName".

+
+Execute the following task to create a distribution with an ASCII armored signature (.asc)
and a SHA512 checksum file (.sha512):
+```
+./gradlew -Pfineract.release clean build 
+```

Review comment:
       My first "reflex" was also to add an explicit task, but have to say that I'm not necessarily
opposed to the way it's now (aka as a side effect of the distribution task). Having said that:
given the short time frame I made a couple of lone decisions so I think it makes a lot of
sense to present this to a broader audience (mailing list) and let them have a say how this
should look like for the next release.
   
   For now I just wanted to have something that helps me during the release.
   
   I'm not sure how this (creating the release via a command line parameter) would impede
different profiles? Let's discuss this on the mailing list or maybe in a separate Jira ticket?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message