fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package
Date Thu, 27 Aug 2020 08:31:17 GMT

vidakovic commented on a change in pull request #1292:
URL: https://github.com/apache/fineract/pull/1292#discussion_r478248382



##########
File path: README.md
##########
@@ -353,6 +353,41 @@ Releasing
 
 [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents the
process how we make the source code that is available here in this Git repository into a binary
release ZIP available on http://fineract.apache.org.
 
+Before you use Gradle to create a release you need to make sure that your GPG is properly
setup and that you have set the following properties in your ~/gradle/gradle.properties:
+```
+signing.gnupg.keyName=7890ABCD
+signing.gnupg.passphrase=secret
+```
+
+IMPORTANT: Do not set your GPG secrets in one of the project gradle.properties and double
check that you are not accidentally committing them to Git.
+

Review comment:
       This section is anyway only intended for a limited audience (I think there are 3 or
4 people right now that can sign the releases). But you have a point here. Happy to change
the default recommendation for the next release. Maybe you can raise that issue then on the
mailing list to see what others have to contribute on that subject?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message