fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on a change in pull request #1292: FINERACT-1129: Gradle task to create release package
Date Thu, 27 Aug 2020 07:56:19 GMT

ptuomola commented on a change in pull request #1292:
URL: https://github.com/apache/fineract/pull/1292#discussion_r478228042



##########
File path: README.md
##########
@@ -353,6 +353,41 @@ Releasing
 
 [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents the
process how we make the source code that is available here in this Git repository into a binary
release ZIP available on http://fineract.apache.org.
 
+Before you use Gradle to create a release you need to make sure that your GPG is properly
setup and that you have set the following properties in your ~/gradle/gradle.properties:
+```
+signing.gnupg.keyName=7890ABCD
+signing.gnupg.passphrase=secret
+```
+
+IMPORTANT: Do not set your GPG secrets in one of the project gradle.properties and double
check that you are not accidentally committing them to Git.
+

Review comment:
       Thanks. I know you can do this either way, I just wondered if it would be better in
the README to suggest that way - rather than suggest that people put it in gradle.properties
AND warn them not to check it in. If the suggested way is to use command line there's no risk
that people will check anything in. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message