fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [fineract] vorburger commented on pull request #1284: add Merge Strategy section to README
Date Wed, 26 Aug 2020 10:30:05 GMT

vorburger commented on pull request #1284:

   > LGTM. Just check the typo as the last line: `Multiple commits in singl PR make sense
in certain cases (e.g. branch backports).`
   Fixed, using Edit on GitHub UI. Which makes this PR itself now have 2 commits, and I'm
too lazy to pull it locally and squash, which makes this an example of a PR that whichever
committers merges this should squash... as this documents. :smile_cat: 
   PS: @awasum et al just just [use GitHub Suggestions](
to propose changes directly! (Instead of only "commenting".)

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message