fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on a change in pull request #1279: FINERACT-854 Removed string concatenated SQL in ClientReadPlatform
Date Tue, 25 Aug 2020 23:31:02 GMT

thesmallstar commented on a change in pull request #1279:
URL: https://github.com/apache/fineract/pull/1279#discussion_r476858480



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLBuilder.java
##########
@@ -122,6 +122,18 @@ public String getSQLTemplate() {
         return "";
     }
 
+    /**
+     * Returns the added criterias, created from the {@link #addCriteria(String, Object)},
with '?' placeholders.
+     *
+     * @return added criterias
+     */
+    public String getCriteria() {
+        if (sb.length() > 0) {
+            return sb.toString();
+        }
+        return "";
+    }
+

Review comment:
       I thought we would need this, initially, since the "where" was already written in a
SQL query which I was not able to replace with sqlBuilder. Please look into other comments,
if solved I think this would resolve (needed/to be removed) itself :) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message