fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #1259: Excluding commented to prevent data leak FINERACT-1057
Date Thu, 20 Aug 2020 02:40:28 GMT

ptuomola commented on pull request #1259:
URL: https://github.com/apache/fineract/pull/1259#issuecomment-676870140


   @maektwain To better understand the problem that this is looking to fix, could you share
some more details on the "data leak" this addresses - how did you identify this, and how can
I reproduce this data leak?  Thanks!
   
   Also it looks like this doesn't pass the first phase of the Travis build i.e. ./gradlew
licenseMain licenseTest licenseIntegrationTest check. Does this phase pass for you locally?
If not, I'd suggest first looking at any issues that are flagged by that test and resolving
those. If it passes for you locally, then we need to understand why Travis gets a different
result...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message