fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)
Date Wed, 12 Aug 2020 19:54:02 GMT

thesmallstar commented on pull request #1242:
URL: https://github.com/apache/fineract/pull/1242#issuecomment-673077724


   @ptuomola I thought not to make them static since they are used in that class itself, I
thought there is no use to make them static since they are not used elsewhere if you think
the static makes more sense I will change it ;)
   
   Should I instead suppress the checkstyle for point "2" then? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message