fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)
Date Wed, 12 Aug 2020 10:04:01 GMT

ptuomola commented on pull request #1242:
URL: https://github.com/apache/fineract/pull/1242#issuecomment-672779492


   Looking at this, the changes seem to fall into a couple of different categories:
   
   - ones where it makes sense - e.g. is_active to isActive
   
   - ones where it in my view doesn't really make sense - e.g. S3, SMS etc are acronyms that
are capitalised, so to make them lowercase just because they are in a variable name seems
strange
   
   - ones where we are taking a fully capitalised variable and making that camelcase. I'm
wondering if these should actually be static constants rather than variables in the first
place?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message