fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #1237: Fixes Swagger-UI for Accrual
Date Thu, 06 Aug 2020 13:08:53 GMT

ptuomola commented on pull request #1237:
URL: https://github.com/apache/fineract/pull/1237#issuecomment-669916044


   Hmm... I thought the idea here was that the actual argument (jsonRequestBody) is hidden,
and instead a "pseudo-argument" is created with the correct schema type using the @Parameter
annotation above the function signature:
   
   @Parameter(required = true, schema = @Schema(implementation = AccrualAccountingApiResourceSwagger.PostRunaccrualsRequest.class,
description = "Request Body\n"
               + "\n" + "Field Descriptions: \n" + "tillDate: \n" + "which specifies periodic
accruals should happen till the given Date"))
   
   So I suppose how this should work is that Swagger would then take the schema from this
annotation but send the serialised object as the request body (instead of requiring you to
type the jsonRequestBody specifically). But as per your note I'm assuming it doesn't work
like that?
   
   Do we actually need both of these parameter definitions? What if we just take the above
annotation's arguments and put those to define the jsonRequestBody parameter instead, and
above this annotation altogether?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message