fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on pull request #1207: FINERACT-1095 Added status parameter in Clients API
Date Tue, 04 Aug 2020 18:13:20 GMT

thesmallstar commented on pull request #1207:
URL: https://github.com/apache/fineract/pull/1207#issuecomment-668748154


   @ptuomola I am collectively answering to your doubts here:
   1. I  am actually adding clients, so there would be some clients in the database for sure.
(Check the first for loop).
   2. I am adding 15 clients and each time I am assigning him pending or active status randomly,
that means
   
   The probability that there are no active/pending clients = 1/pow(2,15) = 0.00003051757,
I hope you will agree we can ignore this and consider that there is at least one active/pending
client. 
   
   3. The client status never actually becomes invalid, it just means that there is no such
status. In that case, we as you said we can either give an exception or show all entries.

   @ptuomola as you said, should we instead throw an exception? still confused or we should
instead show all the clients if it does not map to any of them. 
   
   FYI @vorburger 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message