fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1228: FINERACT-838 TravisCI Setup | Updated swagger-codegen-cli version
Date Sun, 02 Aug 2020 15:11:29 GMT

vorburger commented on a change in pull request #1228:
URL: https://github.com/apache/fineract/pull/1228#discussion_r464089044



##########
File path: fineract-provider/config/swagger/fineract-input.yaml
##########
@@ -22,7 +22,7 @@ info:
     name: Apache 2.0
     url: 'http://www.apache.org/licenses/LICENSE-2.0.html'
 servers:
-- url: /fineract-provider/api/v1
+- url: https://demo.openmf.org/fineract-provider/api/v1

Review comment:
       @Grandolf49 in the interest of moving forward with this, I'll add this to your branch
by self-accepting this suggestion to your PR, and if the build still passes, I'll merge this.
Please comment here if you disagree with changing this URL, and we can discuss it further.
Whatever server we use server is IMHO "wrong" anyway - we should use the LOCAL server - otherwise
this will never work for new APIs being added... I'll comment about this on  FINERACT-838.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message