fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #1179: FINERACT-826 Migrate to java.time from Joda API
Date Sat, 01 Aug 2020 13:57:19 GMT

vorburger commented on pull request #1179:
URL: https://github.com/apache/fineract/pull/1179#issuecomment-667536156


   > @vorburger @awasum @ptuomola Should I create a jira issue for the remaining test since
it is proving quite difficult to reproduce.
   
   Hm. I'm quite torn how to proceed here. In an ideal world, it be neat if we figured out
what is causing that test to still fail, and fix that as part as that PR before merging this.
@ptuomola you actually probably already have the most experience in this area - is this somewhat
similar to those flaky ITs you had managed to stabilize? If we absolutely cannot... hm. Should
we still get this into a possible upcoming 1.4.0, or... hold merging this back to avoid any
"risk", and make this a future 1.5.0 goal?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message