From commits-return-10884-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Fri Jul 3 14:25:13 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 82EF5180667 for ; Fri, 3 Jul 2020 16:25:13 +0200 (CEST) Received: (qmail 18322 invoked by uid 500); 3 Jul 2020 14:25:12 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 18313 invoked by uid 99); 3 Jul 2020 14:25:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jul 2020 14:25:12 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 3CB7D890BA; Fri, 3 Jul 2020 14:25:11 +0000 (UTC) Date: Fri, 03 Jul 2020 14:25:13 +0000 To: "commits@fineract.apache.org" Subject: [fineract] 02/03: FINERACT-822 Enable ProtectedMembersInFinalClass check MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: vorburger@apache.org In-Reply-To: <159378631167.24382.16541835313965152774@gitbox.apache.org> References: <159378631167.24382.16541835313965152774@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: fineract X-Git-Refname: refs/heads/develop X-Git-Reftype: branch X-Git-Rev: 5a16d19564a6754e8787fd4bfe40bc9f54eb04ef X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20200703142512.3CB7D890BA@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. vorburger pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git commit 5a16d19564a6754e8787fd4bfe40bc9f54eb04ef Author: percyashu AuthorDate: Tue Jun 30 09:20:13 2020 +0100 FINERACT-822 Enable ProtectedMembersInFinalClass check --- fineract-provider/build.gradle | 2 +- .../ProvisioningEntriesReadPlatformServiceImpl.java | 2 +- .../infrastructure/dataqueries/domain/Report.java | 2 +- .../dataqueries/domain/ReportParameterUsage.java | 2 +- .../documentmanagement/domain/Image.java | 2 +- .../fineract/portfolio/client/domain/Client.java | 2 +- .../apache/fineract/portfolio/group/domain/Group.java | 2 +- .../domain/LoanRepaymentScheduleInstallment.java | 2 +- .../portfolio/loanaccount/domain/LoanSummary.java | 2 +- .../portfolio/paymentdetail/domain/PaymentDetail.java | 2 +- .../savings/data/FixedDepositProductData.java | 18 +++++++++--------- .../savings/domain/SavingsAccountSummary.java | 2 +- .../savings/domain/SavingsAccountTransaction.java | 2 +- 13 files changed, 21 insertions(+), 21 deletions(-) diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle index 4e4b4d8..9c5dfaa 100644 --- a/fineract-provider/build.gradle +++ b/fineract-provider/build.gradle @@ -395,7 +395,6 @@ tasks.withType(JavaCompile) { "InvalidParam", "ReturnFromVoid", "AlmostJavadoc", - "ProtectedMembersInFinalClass", "InvalidBlockTag", ) //TODO gradually enable these checks @@ -458,6 +457,7 @@ tasks.withType(JavaCompile) { "InvalidInlineTag", "MutablePublicArray", "StaticAssignmentInConstructor", + "ProtectedMembersInFinalClass", "OperatorPrecedence", "EqualsGetClass", "EqualsUnsafeCast", diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java index 915971d..69ec728 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java @@ -67,7 +67,7 @@ public class ProvisioningEntriesReadPlatformServiceImpl implements ProvisioningE private final StringBuilder sqlQuery; - protected LoanProductProvisioningEntryMapper(String formattedDate) { + private LoanProductProvisioningEntryMapper(String formattedDate) { sqlQuery = new StringBuilder().append( "select if(loan.loan_type_enum=1, mclient.office_id, mgroup.office_id) as office_id, loan.loan_type_enum, pcd.criteria_id as criteriaid, loan.product_id,loan.currency_code,") .append("GREATEST(datediff(").append(formattedDate) diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/Report.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/Report.java index 8dbd633..b885361 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/Report.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/Report.java @@ -111,7 +111,7 @@ public final class Report extends AbstractPersistableCustom { return new Report(reportName, reportType, reportSubType, reportCategory, description, useReport, reportSql, reportTypes); } - protected Report() { + Report() { // } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/ReportParameterUsage.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/ReportParameterUsage.java index 2cdc460..d7d2f3a 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/ReportParameterUsage.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/ReportParameterUsage.java @@ -40,7 +40,7 @@ public final class ReportParameterUsage extends AbstractPersistableCustom { @Column(name = "report_parameter_name") private String reportParameterName; - protected ReportParameterUsage() { + ReportParameterUsage() { // } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/domain/Image.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/domain/Image.java index b82b49b..373900f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/domain/Image.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/domain/Image.java @@ -38,7 +38,7 @@ public final class Image extends AbstractPersistableCustom { this.storageType = storageType.getValue(); } - protected Image() { + Image() { } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java index cd218e2..097a537 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java @@ -279,7 +279,7 @@ public final class Client extends AbstractPersistableCustom { savingsAccountId, dataOfBirth, gender, clientType, clientClassification, legalForm, isStaff); } - protected Client() { + Client() { this.setLegalForm(null); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java index 746b311..e318d4c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java @@ -148,7 +148,7 @@ public final class Group extends AbstractPersistableCustom { private List glimLoan; // JPA default constructor for entity - protected Group() { + Group() { this.name = null; this.externalId = null; this.clientMembers = new HashSet<>(); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java index 7172f58..b817571 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java @@ -132,7 +132,7 @@ public final class LoanRepaymentScheduleInstallment extends AbstractAuditableCus @JoinColumn(name = "loan_repayment_schedule_id", referencedColumnName = "id", nullable = false) private Set loanCompoundingDetails = new HashSet<>(); - protected LoanRepaymentScheduleInstallment() { + LoanRepaymentScheduleInstallment() { this.installmentNumber = null; this.fromDate = null; this.dueDate = null; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSummary.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSummary.java index 0eb7da6..bf5ca2f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSummary.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSummary.java @@ -121,7 +121,7 @@ public final class LoanSummary { return new LoanSummary(totalFeeChargesDueAtDisbursement); } - protected LoanSummary() { + LoanSummary() { // } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/paymentdetail/domain/PaymentDetail.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/paymentdetail/domain/PaymentDetail.java index 0eaadb3..8c0cbae 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/paymentdetail/domain/PaymentDetail.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/paymentdetail/domain/PaymentDetail.java @@ -55,7 +55,7 @@ public final class PaymentDetail extends AbstractPersistableCustom { @Column(name = "bank_number", length = 50) private String bankNumber; - protected PaymentDetail() { + PaymentDetail() { } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/FixedDepositProductData.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/FixedDepositProductData.java index 7b580eb..2c61643 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/FixedDepositProductData.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/FixedDepositProductData.java @@ -39,17 +39,17 @@ public final class FixedDepositProductData extends DepositProductData { // additional fields private boolean preClosurePenalApplicable; - protected BigDecimal preClosurePenalInterest; - protected EnumOptionData preClosurePenalInterestOnType; - protected Integer minDepositTerm; - protected Integer maxDepositTerm; + private BigDecimal preClosurePenalInterest; + private EnumOptionData preClosurePenalInterestOnType; + private Integer minDepositTerm; + private Integer maxDepositTerm; private EnumOptionData minDepositTermType; private EnumOptionData maxDepositTermType; - protected Integer inMultiplesOfDepositTerm; - protected EnumOptionData inMultiplesOfDepositTermType; - protected BigDecimal minDepositAmount; - protected BigDecimal depositAmount; - protected BigDecimal maxDepositAmount; + private Integer inMultiplesOfDepositTerm; + private EnumOptionData inMultiplesOfDepositTermType; + private BigDecimal minDepositAmount; + private BigDecimal depositAmount; + private BigDecimal maxDepositAmount; private Collection preClosurePenalInterestOnTypeOptions; private Collection periodFrequencyTypeOptions; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountSummary.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountSummary.java index a15debd..9bc437b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountSummary.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountSummary.java @@ -82,7 +82,7 @@ public final class SavingsAccountSummary { @Column(name = "last_interest_calculation_date") private Date lastInterestCalculationDate; - protected SavingsAccountSummary() { + SavingsAccountSummary() { // } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java index bee444f..bb7269d 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java @@ -130,7 +130,7 @@ public final class SavingsAccountTransaction extends AbstractPersistableCustom { @JoinColumn(name = "savings_account_transaction_id", referencedColumnName = "id") private List notes = new ArrayList<>(); - protected SavingsAccountTransaction() { + SavingsAccountTransaction() { this.dateOf = null; this.typeOf = null; this.createdDate = null;