From commits-return-11226-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon Jul 20 04:28:49 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 2E077180660 for ; Mon, 20 Jul 2020 06:28:49 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 1474812406E for ; Mon, 20 Jul 2020 04:28:48 +0000 (UTC) Received: (qmail 29233 invoked by uid 500); 20 Jul 2020 04:28:46 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 29217 invoked by uid 99); 20 Jul 2020 04:28:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jul 2020 04:28:45 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_ptuomola_commented_on_pull_request_=23?= =?utf-8?q?1166=3A_FINERACT-1054_fixed_sql_grammar_at_loan_repayment?= Message-ID: <159521932478.29655.5816767829453063921.asfpy@gitbox.apache.org> Date: Mon, 20 Jul 2020 04:28:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: ptuomola commented on pull request #1166: URL: https://github.com/apache/fineract/pull/1166#issuecomment-660794602 @vorburger Unfortunately I'm not familiar with the business functionality here - i.e. in what scenarios will we end up with multiple rows for the same due date that need to be grouped - and when we do, how do these rows differ? I agree that this change should fix the SQL error. But just not sure if there are any cases where we would end up with different behaviour than before: i.e. previously we would have had one row returned with values picked at random from the rows being grouped, and now we would end up with multiple rows being returned. If we know that in all cases the rows with the same due date will also have the same other values, then this will naturally never happen... Having said that, at the moment it clearly does not work at all but throws an SQL error - so this is definitely an improvement regardless! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org