From commits-return-11206-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun Jul 19 13:20:55 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id BDAED180660 for ; Sun, 19 Jul 2020 15:20:55 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id EAEE041CED for ; Sun, 19 Jul 2020 13:20:54 +0000 (UTC) Received: (qmail 86163 invoked by uid 500); 19 Jul 2020 13:20:53 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 86154 invoked by uid 99); 19 Jul 2020 13:20:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Jul 2020 13:20:53 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_pull_request_?= =?utf-8?q?=231187=3A_FINERACT-1037=3A_Adding_persistent_volume_for_Fineract?= =?utf-8?q?_imports?= Message-ID: <159516485346.29655.15762104928375363085.asfpy@gitbox.apache.org> Date: Sun, 19 Jul 2020 13:20:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: vorburger commented on pull request #1187: URL: https://github.com/apache/fineract/pull/1187#issuecomment-660642893 I need to refresh my memories about Volumes in Docker to be able to LGTM this... how does this work again - don't you then have to "map" them? Or I'm a confusing Docker Volumes with Kube PV & PVCs :smiling_imp: and this "just works" as is? - More importantly, I think there is another approach for FINERACT-1037... I'll comment there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org