From commits-return-11070-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon Jul 13 22:19:28 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0B2E518037A for ; Tue, 14 Jul 2020 00:19:27 +0200 (CEST) Received: (qmail 44785 invoked by uid 500); 13 Jul 2020 22:19:27 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 44776 invoked by uid 99); 13 Jul 2020 22:19:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2020 22:19:27 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_a_change_in_pul?= =?utf-8?q?l_request_=231149=3A_FINERACT-821_Added_and_Enforced_LocalVariabl?= =?utf-8?q?eName_Checkstyle?= Message-ID: <159467876730.29655.17366975385993685117.asfpy@gitbox.apache.org> Date: Mon, 13 Jul 2020 22:19:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: vorburger commented on a change in pull request #1149: URL: https://github.com/apache/fineract/pull/1149#discussion_r453975083 ########## File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientSavingsIntegrationTest.java ########## @@ -257,22 +257,22 @@ public void testSavingsAccount_WITH_ENFORCE_MIN_BALANCE() { DateFormat dateFormat = new SimpleDateFormat("dd MMMM yyyy"); Calendar todaysDate = Calendar.getInstance(); - final String TRANSACTION_DATE = dateFormat.format(todaysDate.getTime()); + final String transactionDateValue = dateFormat.format(todaysDate.getTime()); Review comment: I actually think this was right (good), because all upper case variable names (on Java), by convention, are ONLY for true static final constants (which to this is not).. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org