From commits-return-10980-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun Jul 5 21:41:45 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 70B7D180652 for ; Sun, 5 Jul 2020 23:41:45 +0200 (CEST) Received: (qmail 26512 invoked by uid 500); 5 Jul 2020 21:41:44 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 26503 invoked by uid 99); 5 Jul 2020 21:41:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Jul 2020 21:41:44 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_francisguchie_commented_on_pull_reques?= =?utf-8?q?t_=231141=3A_FINERACT-1059_add_payment_Voucher_and_Description_to?= =?utf-8?q?_PaymentDetails?= Message-ID: <159398530477.29655.10259398146810820857.asfpy@gitbox.apache.org> Date: Sun, 05 Jul 2020 21:41:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: francisguchie commented on pull request #1141: URL: https://github.com/apache/fineract/pull/1141#issuecomment-653942642 > Run './gradlew :spotlessApply' to fix these violations. > > Also can we make these 2 new parameters optional? > > Where is a voucherNumber coming from? Is it from an external system? or generated by Fineract? the voucher number and Payment description are coming from the users Not generated by the system this can be the slip Number (deposit or withdraw or payment reciept) a good number of financial companies still maintian these slips for audit purposes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org