fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #1207: FINERACT-1095 Added onlyPending parameter(Remove use of sqlSearch)
Date Wed, 29 Jul 2020 07:34:10 GMT

ptuomola commented on pull request #1207:
URL: https://github.com/apache/fineract/pull/1207#issuecomment-665402453


   Hi - great stuff. 
   
   One question: rather than having a boolean flag to check for status 100 only, would it
make sense to make this more generic by making this parameter an int and allowing the caller
of the API to specify any status code as a search parameter? 
   
   Then you could get the same behaviour by calling the API with status = 100, but you could
also use the same parameter for any other status if you wanted? Otherwise I think we run the
risk of over time having to introduce a new boolean for every status type...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message