fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1206: FINERACT-838 Added Swagger Codegen Support
Date Mon, 27 Jul 2020 07:31:34 GMT

vorburger commented on a change in pull request #1206:
URL: https://github.com/apache/fineract/pull/1206#discussion_r460697195



##########
File path: fineract-provider/config/swagger/config.json
##########
@@ -0,0 +1,12 @@
+{
+   "library": "retrofit2",
+   "modelPackage": "org.mifos.models",

Review comment:
       We shouldn't use "org.mifos" for Java package names that are code generated in an Apache
project... how about making this e.g. org.apache.fineract.client?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message