fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [fineract] thesmallstar commented on pull request #1171: FINERACT-854 Removed string concatenated SQL in GroupReadPlatform
Date Fri, 17 Jul 2020 19:24:31 GMT

thesmallstar commented on pull request #1171:

   @vorburger I have summarised what I found in my research:
   Problem -> We are taking SQL from the user for example - a=b and c=d.
   This is then appended directly (with current validations) 
   User input:  a=b&c=d
   output : Select abc from tables.. where  (conditions) and a=b&c=d
   Best Solution I could figure out:
   To make this part of SQL builder we would need to 
   1. Split the user input on and so we get
   A[0]=> a=b
   B[0] => c=d
   And then execute our addCriteria function on each of this input. 
   I am moving forward on this approach and open for suggestions. 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message