fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on pull request #1170: Update dependency org.apache.openjpa:openjpa to v3.1.2
Date Thu, 16 Jul 2020 18:13:26 GMT

awasum commented on pull request #1170:
URL: https://github.com/apache/fineract/pull/1170#issuecomment-659583480


   I am sorry Mike. I missed that. Thanks for highlighting it and adding a
   fix.
   
   On Thu, Jul 16, 2020, 18:37 Michael Vorburger ⛑️ <notifications@github.com>
   wrote:
   
   > *@vorburger* commented on this pull request.
   > ------------------------------
   >
   > In fineract-provider/build.gradle
   > <https://github.com/apache/fineract/pull/1170#discussion_r455957611>:
   >
   > > @@ -47,7 +47,7 @@ buildscript {
   >          classpath 'org.zeroturnaround:gradle-jrebel-plugin:1.1.10'
   >          classpath 'org.springframework.boot:spring-boot-gradle-plugin:2.3.1.RELEASE'
   >          classpath 'gradle.plugin.com.hierynomus.gradle.plugins:license-gradle-plugin:0.15.0'
   > -        classpath 'org.apache.openjpa:openjpa:3.1.1' // when upgrading, also change
OpenJPA version repeated below in dependencyManagement!
   > +        classpath 'org.apache.openjpa:openjpa:3.1.2' // when upgrading, also change
OpenJPA version repeated below in dependencyManagement!
   >
   > @awasum <https://github.com/awasum> did you see the inline comment here?
   > I wrote this hoping so that when we get PRs like this, someone would
   > remember to also do #1180 <https://github.com/apache/fineract/pull/1180>
   > - otherwise they diverge.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fineract/pull/1170#pullrequestreview-450069746>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ADWPAYHLXJY7YR3T7MAVXRTR343GFANCNFSM4OX4BGKQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message