fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on pull request #1179: FINERACT-826 Migrate to java.time from Joda API
Date Wed, 15 Jul 2020 09:17:00 GMT

awasum commented on pull request #1179:
URL: https://github.com/apache/fineract/pull/1179#issuecomment-658651439


   Thats Ok to work on them side by side. I will encourage you to always run the build locally
so that anyone reviewing should not have to stop at spotless failures given that the actual
changes won't even be tested by Travis if spotless is not happy. Keep up the good work.
   
   @vorburger , you might want to keep an eye on this over the next few days and week as this
matures. I feel you have more experience on this given your comment on this on Jira. CC @ptuomola
, @xurror , @thesmallstar .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message