fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Date Tue, 14 Jul 2020 08:09:23 GMT

vorburger commented on a change in pull request #1147:
URL: https://github.com/apache/fineract/pull/1147#discussion_r454180078



##########
File path: fineract-provider/build.gradle
##########
@@ -20,10 +20,17 @@ description = '''\
 Run as:
 gradle clean bootRun'''
 
+group = 'org.apache.fineract'
+buildDir = new File(rootProject.projectDir, "../build")
+
+repositories {
+    jcenter()
+    mavenCentral()

Review comment:
       SGTM. FYI what I meant was specifically the mavenCentral() line - AFAIK jCenter() "proxies"
(mirrors) Maven Central already anyway, so this is unnecessary and probably just slows down
(failed) look ups.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message