fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on a change in pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Date Tue, 14 Jul 2020 02:31:14 GMT

ptuomola commented on a change in pull request #1147:
URL: https://github.com/apache/fineract/pull/1147#discussion_r454061138



##########
File path: fineract-provider/build.gradle
##########
@@ -20,10 +20,17 @@ description = '''\
 Run as:
 gradle clean bootRun'''
 
+group = 'org.apache.fineract'
+buildDir = new File(rootProject.projectDir, "../build")
+
+repositories {
+    jcenter()
+    mavenCentral()

Review comment:
       Hi @vorburger  - welcome back!
   
   The same lines were there, but just hidden half way down the build.gradle file (lines 164-170
in the previous version). All I did was to reorganise the existing content - I was not trying
to make any functional changes at this point, so did not remove any of the settings.
   
   I have another PR ready to further reorganise the content by e.g. grouping all the plugin
configurations together. But once we have the contents structured in a more sensible way,
then it should be easy to see whether all of the settings are actually needed and remove the
ones that are not. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message