fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] francisguchie commented on pull request #1166: FINERACT-1054 fixed sql grammar at loan repayment
Date Mon, 13 Jul 2020 23:27:05 GMT

francisguchie commented on pull request #1166:
URL: https://github.com/apache/fineract/pull/1166#issuecomment-657873337


   > This change looks OK to me, if you say that it fixes the error you described in the
JIRA.. I'm just curious why none of our ITs (tests) hit this- is this not covered by any tests?
Or does the problem which this fixes only appear on some (old?) MySQL version?
   
   This appears on mysSQL 5.7 and above in which full_group_by comes as a default for 5.7
and above
   This is a "systematic" error in the code  the SQL used before works well for MySQL <
5.7 
   
   there is need to make compatibility tests especially where there is change in version especially
the database engine. 
   Backward compatibility could also become an issue. a number of times, newer SQL versions
come with newer keywords which when used the  older versions would not recognize


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message