fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1164: FINERACT-1047 Added integration test for limit param (audit trails)
Date Mon, 13 Jul 2020 23:02:26 GMT

vorburger commented on a change in pull request #1164:
URL: https://github.com/apache/fineract/pull/1164#discussion_r453994511



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AuditIntegrationTest.java
##########
@@ -102,4 +103,29 @@ public void auditShouldbeCreated() {
         auditHelper.verifyOneAuditOnly(auditsRecieved, officeId, "CREATE", "OFFICE");
     }
 
+    /**
+     *
+     * Here we test that audit request with limit x only returns x entries

Review comment:
       Just use "Tests that..." language in the future, or -even better- just use "Tests that..."
language in the future, or -even better- use a method name saying what you document - it's
OK for tests to have long names.. :-)

##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AuditIntegrationTest.java
##########
@@ -102,4 +103,29 @@ public void auditShouldbeCreated() {
         auditHelper.verifyOneAuditOnly(auditsRecieved, officeId, "CREATE", "OFFICE");
     }
 
+    /**
+     *

Review comment:
       Remove such empty comment lines in the future




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message