fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1149: FINERACT-821 Added and Enforced LocalVariableName Checkstyle
Date Mon, 13 Jul 2020 22:33:57 GMT

vorburger commented on a change in pull request #1149:
URL: https://github.com/apache/fineract/pull/1149#discussion_r453984306



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientLoanIntegrationTest.java
##########
@@ -4843,7 +4843,7 @@ public void testLoanRefundByTransferCashBasedAccounting() {
         // refund 20 means paid: principal 1980, interest 240, fees 50, penalty
         // 0
 
-        Float TRANSFER_AMOUNT = 20f;
+        Float transferAmountValue = 20f;

Review comment:
       Ah ok fine, then ignore this (I'm doing some late night review on my mobile phone)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message