fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on a change in pull request #1149: FINERACT-821 Added and Enforced LocalVariableName Checkstyle
Date Mon, 13 Jul 2020 22:27:14 GMT

thesmallstar commented on a change in pull request #1149:
URL: https://github.com/apache/fineract/pull/1149#discussion_r453979703



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AccountingScenarioIntegrationTest.java
##########
@@ -802,10 +802,10 @@ public void checkPeriodicAccrualAccountingTillCurrentDateFlow() throws
Interrupt
 
         float totalInterest = (float) loanSchedule.get(1).get("interestOriginalDue");
         DecimalFormat numberFormat = new DecimalFormat("#.00", new DecimalFormatSymbols(Locale.US));
-        float INTEREST_4_DAYS = totalInterest / totalDaysInPeriod * 4;
-        INTEREST_4_DAYS = Float.valueOf(numberFormat.format(INTEREST_4_DAYS));
+        float interest4Days = totalInterest / totalDaysInPeriod * 4;
+        interest4Days = Float.valueOf(numberFormat.format(interest4Days));

Review comment:
       LocalVariableName would only allow the name to have following type of regex: ^[a-z][a-z0-9][a-zA-Z0-9]*$|[a-z]




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message