fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1149: FINERACT-821 Added and Enforced LocalVariableName Checkstyle
Date Mon, 13 Jul 2020 22:19:27 GMT

vorburger commented on a change in pull request #1149:
URL: https://github.com/apache/fineract/pull/1149#discussion_r453975083



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientSavingsIntegrationTest.java
##########
@@ -257,22 +257,22 @@ public void testSavingsAccount_WITH_ENFORCE_MIN_BALANCE() {
 
         DateFormat dateFormat = new SimpleDateFormat("dd MMMM yyyy");
         Calendar todaysDate = Calendar.getInstance();
-        final String TRANSACTION_DATE = dateFormat.format(todaysDate.getTime());
+        final String transactionDateValue = dateFormat.format(todaysDate.getTime());

Review comment:
       I actually think this was right (good), because all upper case variable names (on Java),
by convention, are ONLY for true static final constants (which to this is not)..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message