fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] xurror commented on a change in pull request #1149: FINERACT-821 Added and Enforced LocalVariableName Checkstyle
Date Sun, 12 Jul 2020 16:41:49 GMT

xurror commented on a change in pull request #1149:
URL: https://github.com/apache/fineract/pull/1149#discussion_r453321228



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientSavingsIntegrationTest.java
##########
@@ -257,22 +257,22 @@ public void testSavingsAccount_WITH_ENFORCE_MIN_BALANCE() {
 
         DateFormat dateFormat = new SimpleDateFormat("dd MMMM yyyy");
         Calendar todaysDate = Calendar.getInstance();
-        final String TRANSACTION_DATE = dateFormat.format(todaysDate.getTime());
+        final String transactionDateValue = dateFormat.format(todaysDate.getTime());

Review comment:
       Did this really need to be renamed? Seems like FOO_BAR format worked pretty well on
other local variables.
   There are other variables you've renamed here too. I think the changes are cool. Maybe
just clarify me on this rename.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message