fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on pull request #1154: Francisguchie fix sql error at loan repayment: FINERACT-1054
Date Mon, 06 Jul 2020 06:45:49 GMT

awasum commented on pull request #1154:
URL: https://github.com/apache/fineract/pull/1154#issuecomment-654046747


   @francisguchie .. I want you to pull this PR down to your local codebase on a separate
branch. Then send a PR from your own repo. I want to make sure you get this right so review
comments can be addressed by you.
   
   next time, before you commit and push code, make sure you have run `./gradlew clean build`
for bulding, `.gradlew bootRun` to test you changes functionally and makes sure they work
from an end user POV and then run ./gradlew integrationTest to make sure integration Tests
are all passing before you commit and push your changes. Go back to all your PRs and makes
sure they are in good shape, they don;t have incompatible and corrupted git history etc. It
is your responsibility (read the README too) to make sure your PR is passing build before
we can review. Please help us help you make more contributions. Read up whatever you don't
yet know and ask questions and we will try to help. I hope you now understand why your PR
was not passing?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message