fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on pull request #1149: FINERACT-821 Added and Enforced LocalVariableName Checkstyle
Date Sun, 05 Jul 2020 22:40:40 GMT

thesmallstar commented on pull request #1149:
URL: https://github.com/apache/fineract/pull/1149#issuecomment-653947886


   @xurror  donot merge this yet, another way to fix this violation was to add a final keyword,
which would fix most of this violations without change in variable name.
   
   On the other hand, AbbreviationAsWordInName did not ignore final variable and did not allow
XYZ_ABC format.
   
   Currently I am looking into AbbreviationAsWordInName's property to ignore final and then
we can decide on what would be the best thing to do.
   
   IMO, we should instead just add the final keyword which would fix nearly all this violations
and this variables dont change the value once assigned.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message