fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1131: FINERACT-822 Enforcing Checks
Date Wed, 01 Jul 2020 09:35:01 GMT

vorburger commented on a change in pull request #1131:
URL: https://github.com/apache/fineract/pull/1131#discussion_r448240409



##########
File path: fineract-provider/src/test/java/org/apache/fineract/common/RestAssuredFixture.java
##########
@@ -33,16 +32,14 @@
  */
 public class RestAssuredFixture {
 
-    private final int httpPort;
+    private final int httpPort = 8443;
 
     private ResponseSpecification responseSpec;
     private RequestSpecification requestSpec;
 
-    public RestAssuredFixture(int httpPort) {
+    public RestAssuredFixture() {
         super();
-        this.httpPort = httpPort;
         Utils.initializeRESTAssured();
-        RestAssured.port = httpPort;

Review comment:
       I was quite surprised that you were able to remove this - how come? Is RestAssured's
default 8443? Isn't it better to keep this explicit?

##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/Report.java
##########
@@ -111,7 +111,7 @@ public static Report fromJson(final JsonCommand command, final Collection<String
         return new Report(reportName, reportType, reportSubType, reportCategory, description,
useReport, reportSql, reportTypes);
     }
 
-    protected Report() {
+    Report() {

Review comment:
       @percyashu couldn't this just be removed, instead of made package local?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message