From commits-return-9926-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun Jun 7 13:12:12 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A116318065B for ; Sun, 7 Jun 2020 15:12:11 +0200 (CEST) Received: (qmail 56559 invoked by uid 500); 7 Jun 2020 13:12:11 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 56550 invoked by uid 99); 7 Jun 2020 13:12:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jun 2020 13:12:10 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_opened_a_new_pull_request_?= =?utf-8?q?=23997=3A_remove_bad_=27default=3A=27_in_SavingsEnumerations_swit?= =?utf-8?q?ch?= Message-ID: Date: Sun, 07 Jun 2020 13:12:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vorburger opened a new pull request #997: URL: https://github.com/apache/fineract/pull/997 This default: is "wrong", because it's not required - the switch, in this particular case, *IS* actually already handling all cases. But if in the future someone were to add an additional new SavingsAccountTransactionType, then we would want Error Prone to fail to signal that it needs to be handled here - but the "default:" would "hide" that. This is a follow-up to https://github.com/apache/fineract/pull/983/ for FINERACT-822, and also related to the discussion started on https://github.com/apache/fineract/pull/989. There originally used to be a "default:" in the middle of the switch, that obviously WAS completely wrong and an old copy-paste bug. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org