From commits-return-10224-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sat Jun 13 03:58:28 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 278161804BB for ; Sat, 13 Jun 2020 05:58:28 +0200 (CEST) Received: (qmail 28148 invoked by uid 500); 13 Jun 2020 03:58:27 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 28137 invoked by uid 99); 13 Jun 2020 03:58:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Jun 2020 03:58:27 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_ptuomola_opened_a_new_pull_request_=23?= =?utf-8?q?1049=3A_FINERACT-857=3A_Fixing_scheduler_integration_tests_and_mi?= =?utf-8?q?grating_to_executeAndAwaitJob?= Message-ID: Date: Sat, 13 Jun 2020 03:58:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ptuomola opened a new pull request #1049: URL: https://github.com/apache/fineract/pull/1049 ## Description Fixed two bugs that were triggered by scheduler integration tests: - Invalid query in SavingsAccountCharge (missing parameters) - Lazy loading not working for m_savings_account.group_id due to transaction boundary Also changed triggering of jobs to use executeAndAwaitJob() and fixed logging for exceptions jobs ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes. - [ ] Integration tests have been created/updated for verifying the changes made. - [ ] All Integrations tests are passing with the new commits. - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.) Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org