From commits-return-10523-archive-asf-public=cust-asf.ponee.io@fineract.apache.org  Sat Jun 20 09:47:13 2020
Return-Path: <commits-return-10523-archive-asf-public=cust-asf.ponee.io@fineract.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id CFAD7180638
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 20 Jun 2020 11:47:12 +0200 (CEST)
Received: (qmail 81558 invoked by uid 500); 20 Jun 2020 09:47:12 -0000
Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@fineract.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@fineract.apache.org>
List-Post: <mailto:commits@fineract.apache.org>
List-Id: <commits.fineract.apache.org>
Reply-To: dev@fineract.apache.org
Delivered-To: mailing list commits@fineract.apache.org
Received: (qmail 81549 invoked by uid 99); 20 Jun 2020 09:47:12 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Jun 2020 09:47:12 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: commits@fineract.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_percyashu_commented_on_a_change_in_pul?=
 =?utf-8?q?l_request_=231092=3A_FINERACT-822_Editing_Checks_list?=
Message-ID: <159264643190.8807.5728823458150730361.asfpy@gitbox.apache.org>
Date: Sat, 20 Jun 2020 09:47:11 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
In-Reply-To: <fineract.1092.MDExOlB1bGxSZXF1ZXN0NDM3Mzc4NTM5.gitbox@gitbox.apache.org>
References: <fineract.1092.MDExOlB1bGxSZXF1ZXN0NDM3Mzc4NTM5.gitbox@gitbox.apache.org>


percyashu commented on a change in pull request #1092:
URL: https://github.com/apache/fineract/pull/1092#discussion_r443117708



##########
File path: fineract-provider/build.gradle
##########
@@ -382,12 +381,10 @@ tasks.withType(JavaCompile) {
                 "ProtectedMembersInFinalClass",
                 "StaticAssignmentInConstructor",
                 "UnescapedEntity",
-                "EmptyCatch",
                 "InvalidBlockTag",
                 "ModifyCollectionInEnhancedForLoop",
                 "NonCanonicalType",
                 "InvalidInlineTag",
-                "InvalidBlockTag"

Review comment:
       Seems check was disable in 2.4.0 and must be enabled as if necessary 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org