From commits-return-10259-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun Jun 14 11:31:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5C6FC180181 for ; Sun, 14 Jun 2020 13:31:02 +0200 (CEST) Received: (qmail 96196 invoked by uid 500); 14 Jun 2020 11:31:01 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 96187 invoked by uid 99); 14 Jun 2020 11:31:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Jun 2020 11:31:01 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_a_change_in_pul?= =?utf-8?q?l_request_=231049=3A_FINERACT-857=3A_Fixing_scheduler_integration?= =?utf-8?q?_tests_and_migrating_to_executeAndAwaitJob?= Message-ID: <159213426107.8807.873838792725713353.asfpy@gitbox.apache.org> Date: Sun, 14 Jun 2020 11:31:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: vorburger commented on a change in pull request #1049: URL: https://github.com/apache/fineract/pull/1049#discussion_r439819898 ########## File path: fineract-provider/src/main/java/org/apache/fineract/scheduledjobs/service/ScheduledJobRunnerServiceImpl.java ########## @@ -229,7 +229,7 @@ public void applyAnnualFeeForSavings() { LOG.error("Apply annual fee failed for account: {} with message {}", savingsAccountReference.getAccountNo(), error); } } catch (final Exception ex) { - // need to handle this scenario + LOG.error("Apply annual fee failed for account: {} with message: {}", savingsAccountReference.getAccountNo(), ex.getMessage()); } Review comment: I see what you mean, but didn't get it initially. For "consistency", let's keep it like you have fixed it, and deal with it if we have overflowing logs, only. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org