From commits-return-10204-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Fri Jun 12 08:50:37 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2A2501804BB for ; Fri, 12 Jun 2020 10:50:37 +0200 (CEST) Received: (qmail 13931 invoked by uid 500); 12 Jun 2020 08:50:36 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 13922 invoked by uid 99); 12 Jun 2020 08:50:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jun 2020 08:50:36 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract-cn-mobile=5D_jawidMuhammadi_commented_on_?= =?utf-8?q?a_change_in_pull_request_=2392=3A_fix=3A_Warning_on_going_back_in?= =?utf-8?q?_forms?= Message-ID: <159195183638.8807.9502203209223381493.asfpy@gitbox.apache.org> Date: Fri, 12 Jun 2020 08:50:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: jawidMuhammadi commented on a change in pull request #92: URL: https://github.com/apache/fineract-cn-mobile/pull/92#discussion_r439292572 ########## File path: app/src/main/java/org/apache/fineract/ui/online/customers/createcustomer/customeractivity/CreateCustomerActivity.java ########## @@ -204,6 +205,20 @@ public void showError(String message) { Toaster.show(findViewById(android.R.id.content), message); } + @Override + public void onBackPressed() { + new MaterialDialog.Builder() Review comment: Yeah I think it is necessary because showing a dialog to the user saying that he will lose his unsaved data even if he didn't enter any data or changed anything, kind of puts the user in doubt and it's unnecessary, and also it is not good from UX point of view. You can implement this by setting a `touch listener` to EditTexts and handle it using a `boolean`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org