From commits-return-10002-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon Jun 8 06:51:16 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AFD2A180647 for ; Mon, 8 Jun 2020 08:51:15 +0200 (CEST) Received: (qmail 94863 invoked by uid 500); 8 Jun 2020 06:51:15 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 94851 invoked by uid 99); 8 Jun 2020 06:51:14 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jun 2020 06:51:14 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract-cn-mobile=5D_jawidMuhammadi_commented_on_?= =?utf-8?q?a_change_in_pull_request_=2389=3A_fix=3A_Differ_fake_data_from_ac?= =?utf-8?q?tual_network_response_in_LoanAccounts?= Message-ID: <159159907488.17834.6499539680892080088.asfpy@gitbox.apache.org> Date: Mon, 08 Jun 2020 06:51:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: jawidMuhammadi commented on a change in pull request #89: URL: https://github.com/apache/fineract-cn-mobile/pull/89#discussion_r436487974 ########## File path: app/src/main/java/org/apache/fineract/data/models/loan/LoanAccount.kt ########## @@ -19,7 +19,8 @@ data class LoanAccount( @SerializedName("createdOn") var createdOn: String? = null, @SerializedName("createdBy") var createdBy: String? = null, @SerializedName("lastModifiedOn") var lastModifiedOn: String? = null, - @SerializedName("lastModifiedBy") var lastModifiedBy: String? = null + @SerializedName("lastModifiedBy") var lastModifiedBy: String? = null, + @SerializedName("isFakeData") var isFakeData: Boolean? = false Review comment: I think it is not a good idea to add attributes to a retrofit model from the client-side and actually we can't modify it. if it is really necessary then it should be added by backend guys first. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org