From commits-return-9847-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Thu Jun 4 22:55:13 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A6355180656 for ; Fri, 5 Jun 2020 00:55:12 +0200 (CEST) Received: (qmail 47673 invoked by uid 500); 4 Jun 2020 22:55:11 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 47663 invoked by uid 99); 4 Jun 2020 22:55:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2020 22:55:11 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_thesmallstar_commented_on_pull_request?= =?utf-8?q?_=23916=3A_FINERACT-942_Added_and_Enforced_EmptyCatchBlock_checks?= =?utf-8?q?tyle?= Message-ID: <159131131175.17834.6551449764836875637.asfpy@gitbox.apache.org> Date: Thu, 04 Jun 2020 22:55:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: thesmallstar commented on pull request #916: URL: https://github.com/apache/fineract/pull/916#issuecomment-639159113 @vorburger I wrote how I approached most of the exceptions in comment. I did not see a major problem(That like what you suggested) please suggest if you have anything on the comments :) If you don't have anything to add, we can just remove the comment and merge this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org