From commits-return-9637-archive-asf-public=cust-asf.ponee.io@fineract.apache.org  Mon Jun  1 10:45:25 2020
Return-Path: <commits-return-9637-archive-asf-public=cust-asf.ponee.io@fineract.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id C60581804BB
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  1 Jun 2020 12:45:24 +0200 (CEST)
Received: (qmail 85247 invoked by uid 500); 1 Jun 2020 10:45:24 -0000
Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@fineract.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@fineract.apache.org>
List-Post: <mailto:commits@fineract.apache.org>
List-Id: <commits.fineract.apache.org>
Reply-To: dev@fineract.apache.org
Delivered-To: mailing list commits@fineract.apache.org
Received: (qmail 85238 invoked by uid 99); 1 Jun 2020 10:45:24 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jun 2020 10:45:24 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: commits@fineract.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_pull_request_?=
 =?utf-8?q?=23948=3A_replace_iText_with_openPDF_=5BFINERACT-965=5D?=
Message-ID: <159100832400.10999.6830610810179612821.asfpy@gitbox.apache.org>
Date: Mon, 01 Jun 2020 10:45:24 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
In-Reply-To: <fineract.948.MDExOlB1bGxSZXF1ZXN0NDI0NzM2MDI0.gitbox@gitbox.apache.org>
References: <fineract.948.MDExOlB1bGxSZXF1ZXN0NDI0NzM2MDI0.gitbox@gitbox.apache.org>


vorburger commented on pull request #948:
URL: https://github.com/apache/fineract/pull/948#issuecomment-636778244


   This is now failing an integration test because of the changes I made here (not flaky), still something with that Base64 change... I haven't been able to entirely understand it - yet. If someone reading along "sees" the problem, please comment, else I'll dig further to figure it out...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org